Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Azure AI Search api key should not be required. #6698

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Python: Azure AI Search api key should not be required. #6698

merged 1 commit into from
Jun 13, 2024

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

We have a regression that makes the AI Search Setting's API key required.

Description

Make the AI Search setting a non-required attribute. Fixes #6697

Contribution Checklist

@moonbox3 moonbox3 requested a review from a team as a code owner June 13, 2024 13:27
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Jun 13, 2024
@moonbox3 moonbox3 mentioned this pull request Jun 13, 2024
Closed
@markwallace-microsoft
Copy link
Member

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL615873588% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1434 1 💤 0 ❌ 0 🔥 18.682s ⏱️

@moonbox3 moonbox3 enabled auto-merge June 13, 2024 13:30
@moonbox3 moonbox3 added this pull request to the merge queue Jun 13, 2024
Merged via the queue into microsoft:main with commit 68ffd1b Jun 13, 2024
25 checks passed
@moonbox3 moonbox3 deleted the non_required_ai_search_key branch June 13, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliomenendez juliomenendez juliomenendez approved these changes

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

Assignees
No one assigned
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python: Bug: api_key missing in AzureAISearchSettings
4 participants
@moonbox3 @markwallace-microsoft @juliomenendez @eavanvalkenburg