-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: instead running two queries now a single query can do the same thing #6705
Merged
dmytrostruk
merged 4 commits into
microsoft:main
from
atiq-bs23:sqlite-memory-connector-improvement
Jun 14, 2024
Merged
.Net: instead running two queries now a single query can do the same thing #6705
dmytrostruk
merged 4 commits into
microsoft:main
from
atiq-bs23:sqlite-memory-connector-improvement
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree |
RogerBarreto
approved these changes
Jun 14, 2024
@RogerBarreto should I remove the InsertOrIgnoreAsync method as there are no other reference where this method used. |
westey-m
reviewed
Jun 14, 2024
westey-m
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Previously the InternalUpsertAsync method was executing two sql query by calling two individual methods - First UpdateAsync and then second InsertOrIgnoreAsync.
The new method uses the INSERT OR REPLACE statement to either update an existing row or insert a new one based on the unique collection and key combination
Contribution Checklist