New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Notebook 04 for invoke_async with context variables #672
Merged
lemillermicrosoft
merged 7 commits into
microsoft:main
from
alexchaomander:fix-notebook-04
Apr 28, 2023
Merged
Fix Notebook 04 for invoke_async with context variables #672
lemillermicrosoft
merged 7 commits into
microsoft:main
from
alexchaomander:fix-notebook-04
Apr 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
awharrison-28
approved these changes
Apr 26, 2023
is the syntax aligned with the version in requirements.txt? |
lemillermicrosoft
approved these changes
Apr 27, 2023
|
github-actions
bot
added
the
kernel
Issues or pull requests impacting the core kernel
label
Apr 28, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context New Python API changes the signature for invoke_async. This aligns it and makes it clearer that the context passed into invoke_async are context variables. This fixes the current issue where the chat function will just repeat back the user input instead of actually chatting --------- Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context New Python API changes the signature for invoke_async. This aligns it and makes it clearer that the context passed into invoke_async are context variables. This fixes the current issue where the chat function will just repeat back the user input instead of actually chatting --------- Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
New Python API changes the signature for invoke_async.
This aligns it and makes it clearer that the context passed into invoke_async are context variables.
This fixes the current issue where the chat function will just repeat back the user input instead of actually chatting