Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notebook 04 for invoke_async with context variables #672

Merged
merged 7 commits into from Apr 28, 2023

Conversation

alexchaomander
Copy link
Contributor

@alexchaomander alexchaomander commented Apr 26, 2023

Motivation and Context

New Python API changes the signature for invoke_async.

This aligns it and makes it clearer that the context passed into invoke_async are context variables.

This fixes the current issue where the chat function will just repeat back the user input instead of actually chatting

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
@dluc
Copy link
Collaborator

dluc commented Apr 27, 2023

is the syntax aligned with the version in requirements.txt?

@alexchaomander
Copy link
Contributor Author

is the syntax aligned with the version in requirements.txt?
Yes!

@github-actions github-actions bot added the kernel Issues or pull requests impacting the core kernel label Apr 28, 2023
@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) April 28, 2023 14:31
@lemillermicrosoft lemillermicrosoft merged commit f4758ff into microsoft:main Apr 28, 2023
11 checks passed
dluc pushed a commit that referenced this pull request Apr 29, 2023
### Motivation and Context
New Python API changes the signature for invoke_async.

This aligns it and makes it clearer that the context passed into
invoke_async are context variables.

This fixes the current issue where the chat function will just repeat
back the user input instead of actually chatting

---------

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
@alexchaomander alexchaomander deleted the fix-notebook-04 branch May 15, 2023 19:09
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
New Python API changes the signature for invoke_async.

This aligns it and makes it clearer that the context passed into
invoke_async are context variables.

This fixes the current issue where the chat function will just repeat
back the user input instead of actually chatting

---------

Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants