Remove some more overhead from GPT3Tokenizer #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We can both simplify and make faster the parsing of the vocab.bpe file - We can remove the SortedDictionary from BytePairEncoding, including a full O(N) iteration of the dictionary on every iteration of the outer loop (as part of the Min() call).
dluc
previously approved these changes
Apr 27, 2023
dluc
approved these changes
Apr 27, 2023
dluc
added a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Some more low-hanging fruit reduction in GPT3Tokenizer. ### Description - We can both simplify and make faster the parsing of the vocab.bpe file - We can remove the SortedDictionary from BytePairEncoding, including a full O(N) iteration of the dictionary on every iteration of the outer loop (as part of the Min() call). Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Devis Lucato <devis@microsoft.com>
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Some more low-hanging fruit reduction in GPT3Tokenizer. ### Description - We can both simplify and make faster the parsing of the vocab.bpe file - We can remove the SortedDictionary from BytePairEncoding, including a full O(N) iteration of the dictionary on every iteration of the outer loop (as part of the Min() call). Co-authored-by: Devis Lucato <dluc@users.noreply.github.com> Co-authored-by: Devis Lucato <devis@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some more low-hanging fruit reduction in GPT3Tokenizer.
Description
Tests before:
Tests after:
Contribution Checklist
dotnet format