Seal internal types #677
Merged
Seal internal types #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would normally be flagged by CA1852, but it's currently unable to handle assemblies marked as InternalsVisibleTo, and all of these assemblies are. Sealing internal types is generally a good practice as a) it can always be changed so there's little downside, b) it can help to communicate to elsewhere in the project whether the type is intended to be derived from (just as using visibility on members communicates what should / shouldn't be used), and c) it can help with performance in some situations, especially on .NET Core.
github-actions
bot
added
.NET
lemillermicrosoft
approved these changes
Apr 26, 2023
lemillermicrosoft
added
the
PR: ready to merge
adrianwyatt
approved these changes
Apr 26, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Seal internal types. ### Description These would normally be flagged by CA1852, but it's currently unable to handle assemblies marked as InternalsVisibleTo, and all of these assemblies are. Sealing internal types is generally a good practice as a) it can always be changed so there's little downside, b) it can help to communicate to elsewhere in the project whether the type is intended to be derived from (just as using visibility on members communicates what should / shouldn't be used), and c) it can help with performance in some situations, especially on .NET Core.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Seal internal types. ### Description These would normally be flagged by CA1852, but it's currently unable to handle assemblies marked as InternalsVisibleTo, and all of these assemblies are. Sealing internal types is generally a good practice as a) it can always be changed so there's little downside, b) it can help to communicate to elsewhere in the project whether the type is intended to be derived from (just as using visibility on members communicates what should / shouldn't be used), and c) it can help with performance in some situations, especially on .NET Core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Seal internal types.
Description
These would normally be flagged by CA1852, but it's currently unable to handle assemblies marked as InternalsVisibleTo, and all of these assemblies are. Sealing internal types is generally a good practice as a) it can always be changed so there's little downside, b) it can help to communicate to elsewhere in the project whether the type is intended to be derived from (just as using visibility on members communicates what should / shouldn't be used), and c) it can help with performance in some situations, especially on .NET Core.
Contribution Checklist
dotnet format