Copilot chat: refactor chat history #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
requested review from
Vivihung,
glahaye,
adrianwyatt and
teresaqhoang
TaoChenOSU
added
PR: ready for review
adrianwyatt
requested changes
Apr 26, 2023
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
adrianwyatt
added
PR: feedback to address
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_history_refactor
branch
2 times, most recently
from
46bc4af
to
6845ebf
Compare
TaoChenOSU
added
PR: ready for review
Vivihung
requested changes
Apr 27, 2023
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/libs/models/ChatMessage.ts
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/libs/services/BaseService.ts
Outdated
Show resolved
Hide resolved
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_history_refactor
branch
from
6845ebf
to
e79a21c
Compare
Vivihung
previously approved these changes
Apr 27, 2023
TaoChenOSU
added
PR: paused
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_history_refactor
branch
from
e79a21c
to
d0a00d3
Compare
github-actions
bot
added
the
kernel
TaoChenOSU
added
PR: ready for review
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_history_refactor
branch
from
d0a00d3
to
3c264ef
Compare
github-actions
bot
added
the
kernel
github-actions
bot
removed
the
kernel
Vivihung
previously approved these changes
Apr 28, 2023
adrianwyatt
requested changes
Apr 28, 2023
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
amsacha
reviewed
Apr 28, 2023
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_history_refactor
branch
from
635c322
to
25c5a6a
Compare
adrianwyatt
approved these changes
Apr 28, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context The chat history skill handles the creation of new chat sessions, retrieval of chat sessions and messages, and editing of chat titles. It was unnecessary and improper to use a skill to handle non-AI related task. ### Description Replace the chat history skill with a controller that provides APIs to handle the above-mentioned tasks.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context The chat history skill handles the creation of new chat sessions, retrieval of chat sessions and messages, and editing of chat titles. It was unnecessary and improper to use a skill to handle non-AI related task. ### Description Replace the chat history skill with a controller that provides APIs to handle the above-mentioned tasks.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context The chat history skill handles the creation of new chat sessions, retrieval of chat sessions and messages, and editing of chat titles. It was unnecessary and improper to use a skill to handle non-AI related task. ### Description Replace the chat history skill with a controller that provides APIs to handle the above-mentioned tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The chat history skill handles the creation of new chat sessions, retrieval of chat sessions and messages, and editing of chat titles. It was unnecessary and improper to use a skill to handle non-AI related task.
Description
Replace the chat history skill with a controller that provides APIs to handle the above-mentioned tasks.
Contribution Checklist
dotnet format