Adding InternalsVisibleTo target in csproj #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
SergeyMenshykh
previously approved these changes
Apr 27, 2023
shawncal
force-pushed
the
internals-visible
branch
from
4df5c2f
to
b0e84d3
Compare
lemillermicrosoft
approved these changes
Apr 27, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context
The current syntax for "InternalsVisibleTo" is ugly, opaque, and spans
multiple lines. This change cleans it up and brings it into compliance
with dotnet 5+ projects.
### Description
Creates a build target that transforms all single line:
`<InternalsVisibleTo Include="SemanticKernelConnectorsSqliteTests"
PublicKey="$(StongNamePublicKey)"/>`
...into the full legacy format:
<AssemblyAttribute
Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>%(InternalsVisibleTo.Identity),
PublicKey="%(InternalsVisibleTo.PublicKey)</_Parameter1>
<_Parameter1_TypeName>System.String</_Parameter1_TypeName>
</AssemblyAttribute>
Note: the PublicKey attribute is included in preparation for strong name
signing, but this change alone does not enable/require strong name
signing. I'd like to remove most of the internalvisibleto attributes
before making that strong name signing change, due to the waterfall of
dependencies they cause.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context
The current syntax for "InternalsVisibleTo" is ugly, opaque, and spans
multiple lines. This change cleans it up and brings it into compliance
with dotnet 5+ projects.
### Description
Creates a build target that transforms all single line:
`<InternalsVisibleTo Include="SemanticKernelConnectorsSqliteTests"
PublicKey="$(StongNamePublicKey)"/>`
...into the full legacy format:
<AssemblyAttribute
Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>%(InternalsVisibleTo.Identity),
PublicKey="%(InternalsVisibleTo.PublicKey)</_Parameter1>
<_Parameter1_TypeName>System.String</_Parameter1_TypeName>
</AssemblyAttribute>
Note: the PublicKey attribute is included in preparation for strong name
signing, but this change alone does not enable/require strong name
signing. I'd like to remove most of the internalvisibleto attributes
before making that strong name signing change, due to the waterfall of
dependencies they cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The current syntax for "InternalsVisibleTo" is ugly, opaque, and spans multiple lines. This change cleans it up and brings it into compliance with dotnet 5+ projects.
Description
Creates a build target that transforms all single line:
<InternalsVisibleTo Include="SemanticKernelConnectorsSqliteTests" PublicKey="$(StongNamePublicKey)"/>...into the full legacy format:
<_Parameter1>%(InternalsVisibleTo.Identity), PublicKey="%(InternalsVisibleTo.PublicKey)</_Parameter1>
<_Parameter1_TypeName>System.String</_Parameter1_TypeName>
Note: the PublicKey attribute is included in preparation for strong name signing, but this change alone does not enable/require strong name signing. I'd like to remove most of the internalvisibleto attributes before making that strong name signing change, due to the waterfall of dependencies they cause.
Contribution Checklist
dotnet format