Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MinHeap internal #695

Merged
merged 1 commit into from Apr 27, 2023
Merged

Make MinHeap internal #695

merged 1 commit into from Apr 27, 2023

Conversation

stephentoub
Copy link
Member

Motivation and Context

Fixes #615. Avoid exposing unnecessary public surface area.

Description

.NET has a production-grade PriorityQueue<>, it's just not available for netstandard2.0.

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels Apr 27, 2023
@lemillermicrosoft lemillermicrosoft added PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge. labels Apr 27, 2023
@lemillermicrosoft lemillermicrosoft merged commit abfbb5a into microsoft:main Apr 27, 2023
11 checks passed
dluc pushed a commit that referenced this pull request Apr 29, 2023
@stephentoub @dluc
Make MinHeap internal (#695)
5018d37 
### Motivation and Context

Fixes #615. Avoid
exposing unnecessary public surface area.

### Description

.NET has a production-grade `PriorityQueue<>`, it's just not available
for netstandard2.0.
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
@stephentoub
Make MinHeap internal (microsoft#695)
c6904f6 
### Motivation and Context

Fixes microsoft#615. Avoid
exposing unnecessary public surface area.

### Description

.NET has a production-grade `PriorityQueue<>`, it's just not available
for netstandard2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemillermicrosoft lemillermicrosoft lemillermicrosoft approved these changes

Assignees
No one assigned
Labels
.NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we make MinHeap internal?
2 participants
@stephentoub @lemillermicrosoft