Qdrant: don't throw on 404 when getting nearest match #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianwyatt
added
bug
TaoChenOSU
approved these changes
Apr 27, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context Qdrant was failing in CopilotChat on first use when querying for vectors in collections that don't exist yet. ### Description - Swallow 404s from Qdrant when querying for nearest match.
5 tasks
|
There's quite a bit of work going into fixing this in the MemoryStore for a check that's uniformly handled in the DbClient. Please take a look at the PR for #719 and consider if we should approach resolving in this manner. |
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Qdrant was failing in CopilotChat on first use when querying for vectors in collections that don't exist yet. ### Description - Swallow 404s from Qdrant when querying for nearest match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Qdrant was failing in CopilotChat on first use when querying for vectors in collections that don't exist yet.
Description