Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of deployment templates and scripts #704

Merged
merged 39 commits into from May 2, 2023
Merged

Addition of deployment templates and scripts #704

merged 39 commits into from May 2, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Apr 27, 2023

Motivation and Context

We want to make it easy to set up and use the Copilot Chat in a cloud setting.

Description

  • Added bicep deployment templates and scripts
  • Added related documentation
  • Added ARM template equivalents to the bicep files (only ARM is supported for "Deploy to Azure" buttons)

Contribution Checklist

@glahaye glahaye added the PR: ready for review All feedback addressed, ready for reviews label Apr 27, 2023
@glahaye glahaye changed the title Deploy Addition of deployment templates and scripts Apr 27, 2023
@glahaye
Copy link
Contributor Author

glahaye commented May 1, 2023

Why only Powershell and no Bash?

Neither PowerShell nor Bash are needed to deploy the templates. They can be deployed by simply using the Azure CLI or the "Deploy to Azure" button.

The PowerShell scripts are merely a convenience. Why PowerShell? Because it's one of the two shells directly supported as Azure shells (the other being cmd) and, of the two, it's the only one available on all of Windows, Mac and Linux.

Adding bash versions of the scripts won't give us that much but will force us to maintain them when/if ever we need to modify the PowerShell scripts.

As such, I'm not keen on adding bash versions of the scripts. However, if you do really believe that they add value, I will add them.

Let me know either way.

@glahaye glahaye added PR: ready for review All feedback addressed, ready for reviews and removed PR: feedback to address Waiting for PR owner to address comments/questions labels May 1, 2023
adrianwyatt
adrianwyatt previously approved these changes May 1, 2023
@adrianwyatt adrianwyatt added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels May 1, 2023
Vivihung
Vivihung previously approved these changes May 1, 2023
@hathind-ms
Copy link
Contributor

Why only Powershell and no Bash?

Neither PowerShell nor Bash are needed to deploy the templates. They can be deployed by simply using the Azure CLI or the "Deploy to Azure" button.

The PowerShell scripts are merely a convenience. Why PowerShell? Because it's one of the two shells directly supported as Azure shells (the other being cmd) and, of the two, it's the only one available on all of Windows, Mac and Linux.

Adding bash versions of the scripts won't give us that much but will force us to maintain them when/if ever we need to modify the PowerShell scripts.

As such, I'm not keen on adding bash versions of the scripts. However, if you do really believe that they add value, I will add them.

Let me know either way.

I am okay with having PS scripts only as step 1. We can add Bash scripts later if needed.

hathind-ms
hathind-ms previously approved these changes May 2, 2023
@glahaye glahaye dismissed stale reviews from hathind-ms, Vivihung, and adrianwyatt via 2228503 May 2, 2023 02:34
@dluc dluc dismissed their stale review May 2, 2023 05:43

thanks for adding the bash script! ⭐️

@dluc dluc enabled auto-merge (squash) May 2, 2023 05:44
@dluc dluc merged commit 8e232e0 into microsoft:main May 2, 2023
11 checks passed
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
### Motivation and Context
We want to make it easy to set up and use the Copilot Chat in a cloud setting.

### Description
- Added bicep deployment templates and scripts
- Added related documentation
- Added ARM template equivalents to the bicep files (only ARM is supported for "Deploy to Azure" buttons)
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
We want to make it easy to set up and use the Copilot Chat in a cloud setting.

### Description
- Added bicep deployment templates and scripts
- Added related documentation
- Added ARM template equivalents to the bicep files (only ARM is supported for "Deploy to Azure" buttons)
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
We want to make it easy to set up and use the Copilot Chat in a cloud setting.

### Description
- Added bicep deployment templates and scripts
- Added related documentation
- Added ARM template equivalents to the bicep files (only ARM is supported for "Deploy to Azure" buttons)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants