Copilot Chat: Include doc memory in upload/download a bot file #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kernel
Vivihung
added
PR: ready for review
TaoChenOSU
reviewed
Apr 28, 2023
samples/apps/copilot-chat-app/webapi/Controllers/BotController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/BotController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/BotController.cs
Outdated
Show resolved
Hide resolved
Vivihung
changed the title
adrianwyatt
added
PR: feedback to address
Vivihung
added
PR: ready for review
TaoChenOSU
previously approved these changes
May 1, 2023
adrianwyatt
requested changes
May 1, 2023
samples/apps/copilot-chat-app/webapi/Controllers/BotController.cs
Outdated
Show resolved
Hide resolved
adrianwyatt
requested changes
May 1, 2023
samples/apps/copilot-chat-app/webapi/Controllers/BotController.cs
Outdated
Show resolved
Hide resolved
adrianwyatt
added
PR: feedback to address
Vivihung
added
PR: ready for review
adrianwyatt
approved these changes
May 2, 2023
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
…soft#711) ### Motivation and Context Include doc memory in upload/download a bot file. ### Description 1. Add a document embedding filed into the bot schema. 2. Include doc memory when downloading a bot file. For user scope doc memory, the user object id will be replaced by chat id as a workaround. Eventually, we want to make doc memory to chat session scope. 3. Import the doc embedding as regular chat session embeddings. (We don't use the doc memory collection name when import. Things will get clear when we move doc memory to chat session scope.)
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…soft#711) ### Motivation and Context Include doc memory in upload/download a bot file. ### Description 1. Add a document embedding filed into the bot schema. 2. Include doc memory when downloading a bot file. For user scope doc memory, the user object id will be replaced by chat id as a workaround. Eventually, we want to make doc memory to chat session scope. 3. Import the doc embedding as regular chat session embeddings. (We don't use the doc memory collection name when import. Things will get clear when we move doc memory to chat session scope.)
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…soft#711) ### Motivation and Context Include doc memory in upload/download a bot file. ### Description 1. Add a document embedding filed into the bot schema. 2. Include doc memory when downloading a bot file. For user scope doc memory, the user object id will be replaced by chat id as a workaround. Eventually, we want to make doc memory to chat session scope. 3. Import the doc embedding as regular chat session embeddings. (We don't use the doc memory collection name when import. Things will get clear when we move doc memory to chat session scope.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Include doc memory in upload/download a bot file.
Description
Contribution Checklist
dotnet formatAll unit tests pass, and I have added new tests where possible