Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar Only Correction #715

Merged
merged 2 commits into from Apr 28, 2023
Merged

Grammar Only Correction #715

merged 2 commits into from Apr 28, 2023

Conversation

MorbidKoder
Copy link
Contributor

@MorbidKoder MorbidKoder commented Apr 28, 2023

grammar changed from "Let's now revisit the our chat sample from the" to "Let's now revisit our chat sample from the"

Motivation and Context

Why is this change required?

This change is required to fix the grammatical error in the sentence.

What problem does it solve?

This change solves the problem of incorrect grammar in the sentence.

What scenario does it contribute to?

This change contributes to the scenario where we want to have correct grammar in our chat sample.

If it fixes an open issue, please link to the issue here.

Since this change does not fix an open issue, there is no link to provide.

Description

I have made a change to the grammar in the sentence by removing the word ‘the’ which was causing the sentence to be grammatically incorrect. The overall approach I took was to identify the error in the sentence and then make the necessary changes to fix it. The underlying design of this change is to ensure that our chat sample has correct grammar and is easy to understand for our users.

Contribution Checklist

grammar changed from "Let's now revisit the our chat sample from the" to "Let's now revisit our chat sample from the"
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples labels Apr 28, 2023
@shawncal
Copy link
Member

You win the best PR description award!

Next time, check out PRSkill: A skill that can generate feedback, commit messages, and pull request descriptions based on git diff or git show output. The PRSkill uses the CondenseSkill as a dependency and implements chunking and aggregation mechanisms to handle large inputs.
https://github.com/lemillermicrosoft/skonsole

You'll never have to write another PR description again!
CC @lemillermicrosoft

Thanks for the change!

@shawncal shawncal merged commit 51f77ca into microsoft:main Apr 28, 2023
11 checks passed
@MorbidKoder
Copy link
Contributor Author

Thank you! I will need to check that out. It was fun to write though!

@MorbidKoder MorbidKoder deleted the patch-1 branch April 28, 2023 04:16
dluc pushed a commit that referenced this pull request Apr 29, 2023
grammar changed from "Let's now revisit the our chat sample from the" to
"Let's now revisit our chat sample from the"
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
grammar changed from "Let's now revisit the our chat sample from the" to
"Let's now revisit our chat sample from the"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants