Improve labeler rules for kernel label #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
kernel
lemillermicrosoft
added
PR: ready for review
lemillermicrosoft
force-pushed
the
427_label_2
branch
from
c9e49dd
to
6441330
Compare
This commit updates the .github/labeler.yml file to better match the changes in the dotnet/src directory. It simplifies the rules for the 'kernel' label and adds a new rule for the 'SemanticKernel.MetaPackage' project. It also removes some redundant patterns that are already covered by the '**/*' glob. This will help to automatically assign labels to pull requests that affect the kernel or .NET projects.
lemillermicrosoft
force-pushed
the
427_label_2
branch
from
6441330
to
df1c61d
Compare
shawncal
approved these changes
Apr 28, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
### Motivation and Context #710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. lemillermicrosoft#7 lemillermicrosoft#8 lemillermicrosoft#10 lemillermicrosoft#9 This one was missed before.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context microsoft#710 tried to enable the `kernel` tag but accidentally applied to too many changes. ### Description The best way to resolve this was specify directories under `dotnet` to be considered for `kernel`. #7 #8 #10 #9 This one was missed before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#710 tried to enable the
kerneltag but accidentally applied to too many changes.Description
The best way to resolve this was specify directories under
dotnetto be considered forkernel.lemillermicrosoft#7
lemillermicrosoft#8
lemillermicrosoft#10
lemillermicrosoft#9 This one was missed before.
Contribution Checklist
dotnet format