New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge KernelConfig with Kernel #731
Conversation
… remove-kernel-config
…ntic-kernel into remove-kernel-config
Looks like there are conflicts to resolve in notebook 5, otherwise, LGTM |
… remove-kernel-config
I'm far from a strong Python engineer but have been cloning this repo to learn about the Semantic Kernel. This change breaks all the Python notebooks. To continue my learning I need to reverse the changes that were made. I guess the notebooks aren't as "Pythonic" as they should be, whatever that means, but at least they worked. Given that this is code for introducing some of the basics I would highly recommend that the code work. This change provides no value at all, exactly the opposite. |
### Motivation and Context KernelConfig isn't needed as it's less pythonic and is not used independently from Kernel. This moves all its methods and members into Kernel. ### Description - Removed KernelConfig - Put KernelConfig's methods and variables into Kernel - Ran unit and end-to-end tests - Did not run notebooks because they are out of date with the current repo. --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
### Motivation and Context KernelConfig isn't needed as it's less pythonic and is not used independently from Kernel. This moves all its methods and members into Kernel. ### Description - Removed KernelConfig - Put KernelConfig's methods and variables into Kernel - Ran unit and end-to-end tests - Did not run notebooks because they are out of date with the current repo. --------- Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
Motivation and Context
KernelConfig isn't needed as it's less pythonic and is not used independently from Kernel. This moves all its methods and members into Kernel.
Description
Contribution Checklist
dotnet format