Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and code style #741

Merged
merged 4 commits into from May 1, 2023
Merged

Fix typos and code style #741

merged 4 commits into from May 1, 2023

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented Apr 29, 2023 •
edited

  • Fix filename containing a space (ApiKeyAuthenticationHandler .cs)
  • Fix typos
  • Fix code style
  • Add missing rule for local constants
  • Add commented code to automate code style checks. These don't work with .NET Standard 2.0, so we'll need some extra research.
  • Fix one incorrect ILogger naming
  • Add some TODOs about unused code
  • Fix xmldocs

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples labels Apr 29, 2023
@dluc dluc added the PR: ready for review All feedback addressed, ready for reviews label Apr 29, 2023
shawncal
shawncal previously requested changes Apr 30, 2023
View reviewed changes
.editorconfig Outdated Show resolved Hide resolved
@dluc dluc dismissed shawncal’s stale review April 30, 2023 23:43

Moved to PascalCase

@adrianwyatt adrianwyatt enabled auto-merge (squash) May 1, 2023 17:42
@adrianwyatt adrianwyatt added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels May 1, 2023
@adrianwyatt adrianwyatt merged commit e8dced1 into microsoft:main May 1, 2023
11 checks passed
awharrison-28 pushed a commit to awharrison-28/semantic-kernel that referenced this pull request May 1, 2023
@dluc @awharrison-28
Fix typos and code style (microsoft#741)
b900c46 
* Fix filename containing a space (`ApiKeyAuthenticationHandler .cs`)
* Fix typos
* Fix code style
* Add missing rule for local constants
* Add commented code to automate code style checks. These don't work
with .NET Standard 2.0, so we'll need some extra research.
* Fix one incorrect ILogger naming
* Add some TODOs about unused code
* Fix xmldocs
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
@dluc @codebrain
Fix typos and code style (microsoft#741)
097cb62 
* Fix filename containing a space (`ApiKeyAuthenticationHandler .cs`)
* Fix typos
* Fix code style
* Add missing rule for local constants
* Add commented code to automate code style checks. These don't work
with .NET Standard 2.0, so we'll need some extra research.
* Fix one incorrect ILogger naming
* Add some TODOs about unused code
* Fix xmldocs
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
@dluc
Fix typos and code style (microsoft#741)
4a7d80f 
* Fix filename containing a space (`ApiKeyAuthenticationHandler .cs`)
* Fix typos
* Fix code style
* Add missing rule for local constants
* Add commented code to automate code style checks. These don't work
with .NET Standard 2.0, so we'll need some extra research.
* Fix one incorrect ILogger naming
* Add some TODOs about unused code
* Fix xmldocs
@dluc dluc deleted the dluc132codestyle branch June 14, 2023 01:14
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
@dluc
Fix typos and code style (microsoft#741)
db9acbf 
* Fix filename containing a space (`ApiKeyAuthenticationHandler .cs`)
* Fix typos
* Fix code style
* Add missing rule for local constants
* Add commented code to automate code style checks. These don't work
with .NET Standard 2.0, so we'll need some extra research.
* Fix one incorrect ILogger naming
* Add some TODOs about unused code
* Fix xmldocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub left review comments

@adrianwyatt adrianwyatt adrianwyatt approved these changes

@shawncal shawncal shawncal left review comments

Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dluc @stephentoub @shawncal @adrianwyatt