Fix potential multiple enumerations #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
stephentoub
reviewed
Apr 30, 2023
stephentoub
reviewed
Apr 30, 2023
stephentoub
reviewed
Apr 30, 2023
samples/apps/copilot-chat-app/webapi/Controllers/ChatHistoryController.cs
Outdated
Show resolved
Hide resolved
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dluc
force-pushed
the
dluc133enumerations
branch
from
534510e
to
3506f6d
Compare
adrianwyatt
approved these changes
May 1, 2023
adrianwyatt
added
PR: ready to merge
awharrison-28
pushed a commit
to awharrison-28/semantic-kernel
that referenced
this pull request
May 1, 2023
There are more of these in unit tests and samples, where I think it's not a big deal. The PR fixes code in the SDK (one false positive simply resolved using ICollection) and code that could be copied into other projects. Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
There are more of these in unit tests and samples, where I think it's not a big deal. The PR fixes code in the SDK (one false positive simply resolved using ICollection) and code that could be copied into other projects. Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
There are more of these in unit tests and samples, where I think it's not a big deal. The PR fixes code in the SDK (one false positive simply resolved using ICollection) and code that could be copied into other projects. Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
There are more of these in unit tests and samples, where I think it's not a big deal. The PR fixes code in the SDK (one false positive simply resolved using ICollection) and code that could be copied into other projects. Co-authored-by: Adrian Bonar <56417140+adrianwyatt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more of these in unit tests and samples, where I think it's not a big deal. The PR fixes code in the SDK (one false positive simply resolved using ICollection) and code that could be copied into other projects.