Remove duplicative extension methods on KernelPlanExtensions #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
shawncal
approved these changes
May 1, 2023
These are all handled by the corresponding overload that takes an optional CancellationToken.
shawncal
force-pushed
the
kernelplanextensions
branch
from
77494dc
to
47a5615
Compare
awharrison-28
pushed a commit
to awharrison-28/semantic-kernel
that referenced
this pull request
May 1, 2023
…ft#750) These are all handled by the corresponding overload that takes an optional CancellationToken. Their presence also means the optionality of the tokens in the other overloads would never actually be used.
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
…ft#750) These are all handled by the corresponding overload that takes an optional CancellationToken. Their presence also means the optionality of the tokens in the other overloads would never actually be used.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
…ft#750) These are all handled by the corresponding overload that takes an optional CancellationToken. Their presence also means the optionality of the tokens in the other overloads would never actually be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove unnecessary overloads
Description
These are all handled by the corresponding overload that takes an optional CancellationToken. Their presence also means the optionality of the tokens in the other overloads would never actually be used.
Contribution Checklist
dotnet formatcc: @shawncal, @dluc