Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopilotChat: Migrate to ActionPlanner #765

Merged
merged 17 commits into from May 2, 2023

Conversation

adrianwyatt
Copy link
Contributor

@adrianwyatt adrianwyatt commented May 2, 2023

Motivation and Context

The SequentialPlanner needs GPT-4 to operate with relative consistency and correctness. Using ActionPlanner simplifies the planning feature set but also allows us to use gpt-3.5-turbo with single step plans.

Description

  • Updated CopilotChat planner feature flag to enabled=true
  • Updated CopilotChatPlanner to use ActionPlanner (single step planner)
  • Added an AIService configuration for CopilotChat's planner to disaggregate the completion model with the planner model.
  • CopilotChat won't invoke plans with no steps.
  • Removed core and semantic skills from CopilotChat planner manuals
  • ActionPlanner: Added support for non-string parameters
  • ActionPlanner: Added JSON property sanitation to 'rationale' values (replace double quotes with single and remove newlines)
  • ActionPlanner: fixed JSON bug when no relevant function is found (extra close curly brace)

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples labels May 2, 2023
@adrianwyatt adrianwyatt added the PR: ready for review All feedback addressed, ready for reviews label May 2, 2023
@adrianwyatt adrianwyatt self-assigned this May 2, 2023
@adrianwyatt adrianwyatt marked this pull request as ready for review May 2, 2023 05:00
@adrianwyatt adrianwyatt requested a review from dluc May 2, 2023 05:05
dluc

This comment was marked as resolved.

dluc

This comment was marked as resolved.

@dluc dluc dismissed their stale review May 2, 2023 17:51

Design discussed offline. Please send test cases, I'll write some functional/regression tests

amsacha
amsacha previously approved these changes May 2, 2023
hathind-ms
hathind-ms previously approved these changes May 2, 2023
@adrianwyatt adrianwyatt dismissed stale reviews from hathind-ms and amsacha via a0d5aca May 2, 2023 18:45
@adrianwyatt adrianwyatt enabled auto-merge (squash) May 2, 2023 18:47
@adrianwyatt adrianwyatt merged commit cd3ec2a into microsoft:main May 2, 2023
11 checks passed
@adrianwyatt adrianwyatt deleted the planner-v3 branch May 4, 2023 00:32
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
The SequentialPlanner needs GPT-4 to operate with relative consistency
and correctness. Using ActionPlanner simplifies the planning feature set
but also allows us to use gpt-3.5-turbo with single step plans.

- Updated CopilotChat planner feature flag to enabled=true
- Updated CopilotChatPlanner to use ActionPlanner (single step planner)
- Added an AIService configuration for CopilotChat's planner to
disaggregate the completion model with the planner model.
- CopilotChat won't invoke plans with no steps.
- Removed core and semantic skills from CopilotChat planner manuals
- ActionPlanner: Added support for non-string parameters
- ActionPlanner: Added JSON property sanitation to 'rationale' values
(replace double quotes with single and remove newlines)
- ActionPlanner: fixed JSON bug when no relevant function is found
(extra close curly brace)
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
The SequentialPlanner needs GPT-4 to operate with relative consistency
and correctness. Using ActionPlanner simplifies the planning feature set
but also allows us to use gpt-3.5-turbo with single step plans.

### Description
- Updated CopilotChat planner feature flag to enabled=true
- Updated CopilotChatPlanner to use ActionPlanner (single step planner)
- Added an AIService configuration for CopilotChat's planner to
disaggregate the completion model with the planner model.
- CopilotChat won't invoke plans with no steps.
- Removed core and semantic skills from CopilotChat planner manuals
- ActionPlanner: Added support for non-string parameters
- ActionPlanner: Added JSON property sanitation to 'rationale' values
(replace double quotes with single and remove newlines)
- ActionPlanner: fixed JSON bug when no relevant function is found
(extra close curly brace)
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
The SequentialPlanner needs GPT-4 to operate with relative consistency
and correctness. Using ActionPlanner simplifies the planning feature set
but also allows us to use gpt-3.5-turbo with single step plans.

### Description
- Updated CopilotChat planner feature flag to enabled=true
- Updated CopilotChatPlanner to use ActionPlanner (single step planner)
- Added an AIService configuration for CopilotChat's planner to
disaggregate the completion model with the planner model.
- CopilotChat won't invoke plans with no steps.
- Removed core and semantic skills from CopilotChat planner manuals
- ActionPlanner: Added support for non-string parameters
- ActionPlanner: Added JSON property sanitation to 'rationale' values
(replace double quotes with single and remove newlines)
- ActionPlanner: fixed JSON bug when no relevant function is found
(extra close curly brace)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants