Copilot chat: Avoid duplication in document memories #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaoChenOSU
added
PR: ready for review
TaoChenOSU
changed the title
adrianwyatt
requested changes
May 3, 2023
adrianwyatt
added
PR: feedback to address
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_deduplicate_document_memory
branch
from
bc56294
to
5e80d1e
Compare
TaoChenOSU
added
PR: ready for review
glahaye
reviewed
May 5, 2023
samples/apps/copilot-chat-app/webapi/Config/DocumentMemoryOptions.cs
Outdated
Show resolved
Hide resolved
glahaye
reviewed
May 5, 2023
samples/apps/copilot-chat-app/webapi/Controllers/DocumentImportController.cs
Show resolved
Hide resolved
adrianwyatt
previously approved these changes
May 8, 2023
adrianwyatt
added
PR: ready to merge
TaoChenOSU
force-pushed
the
users/taochen/copilot_chat_deduplicate_document_memory
branch
from
a5f593a
to
3f3a72e
Compare
glahaye
approved these changes
May 8, 2023
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Importing documents in Copilot chat will not check for duplication. This will potentially create issues where the same documents are uploaded multiple times. ### Description 1. Enable the document import controller to check for duplication before saving a new memory to the document memory. 2. Allow developers to configure the threshold of duplication (similarity score) in the settings. 3. Move a couple hard-coded similarity score settings to settings.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context Importing documents in Copilot chat will not check for duplication. This will potentially create issues where the same documents are uploaded multiple times. ### Description 1. Enable the document import controller to check for duplication before saving a new memory to the document memory. 2. Allow developers to configure the threshold of duplication (similarity score) in the settings. 3. Move a couple hard-coded similarity score settings to settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Importing documents in Copilot chat will not check for duplication. This will potentially create issues where the same documents are uploaded multiple times.
Description
Contribution Checklist
dotnet format