Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in type hint #784

Merged
merged 3 commits into from May 4, 2023
Merged

fix typo in type hint #784

merged 3 commits into from May 4, 2023

Conversation

hsm207
Copy link
Contributor

@hsm207 hsm207 commented May 3, 2023

Motivation and Context

  1. Why is this change required?
    Fix a typo in type hints
  2. What problem does it solve?
    Provide accurate information
  3. What scenario does it contribute to?
    People reading type hints
  4. If it fixes an open issue, please link to the issue here.
    NA

Description

collection_name: SystemError -> collection_name: str

Contribution Checklist

@hsm207
fix typo in type hint
d1f9040 
collection_name: SystemError -> collection_name: str
@github-actions github-actions bot added the python Pull requests for the Python Semantic Kernel label May 3, 2023
@awharrison-28 awharrison-28 added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 3, 2023
@dluc dluc enabled auto-merge (squash) May 4, 2023 23:57
@dluc dluc merged commit 42fae73 into microsoft:main May 4, 2023
21 checks passed
@hsm207 hsm207 deleted the memorystore-typo branch May 5, 2023 03:29
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
@hsm207 @codebrain
fix typo in type hint (microsoft#784)
240604c 
Fix a typo in type hints

collection_name: SystemError -> collection_name: str
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
@hsm207
fix typo in type hint (microsoft#784)
8216e53 
Fix a typo in type hints

collection_name: SystemError -> collection_name: str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluc dluc dluc approved these changes

@awharrison-28 awharrison-28 awharrison-28 approved these changes

Assignees
No one assigned
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsm207 @dluc @awharrison-28