Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method name is added to exception message. #787

Merged
merged 2 commits into from May 6, 2023

Conversation

SergeyMenshykh
Copy link
Member

Motivation, Context and Description

This PR adds function/method name into exception message that is thrown if a native function, marked with SKFunctionInputAttribute, doesn't have an input parameter of string type. The method name can be useful for debugging and troubleshooting.

Contribution Checklist

@SergeyMenshykh SergeyMenshykh added the PR: ready for review All feedback addressed, ready for reviews label May 3, 2023
@SergeyMenshykh SergeyMenshykh requested a review from dluc May 3, 2023 14:30
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel.core labels May 3, 2023
@adrianwyatt adrianwyatt requested a review from shawncal May 5, 2023 00:22
@adrianwyatt adrianwyatt removed their assignment May 5, 2023
@SergeyMenshykh SergeyMenshykh requested review from lemillermicrosoft and removed request for lemillermicrosoft May 5, 2023 14:48
@shawncal shawncal force-pushed the improve-exception-message branch from c67ea62 to 50a32ac Compare May 6, 2023 05:34
@shawncal shawncal enabled auto-merge (squash) May 6, 2023 05:35
@shawncal shawncal merged commit 22d12cb into microsoft:main May 6, 2023
9 checks passed
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
### Motivation, Context and Description
This PR adds function/method name into exception message that is thrown
if a native function, marked with SKFunctionInputAttribute, doesn't have
an input parameter of string type. The method name can be useful for
debugging and troubleshooting.
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation, Context and Description
This PR adds function/method name into exception message that is thrown
if a native function, marked with SKFunctionInputAttribute, doesn't have
an input parameter of string type. The method name can be useful for
debugging and troubleshooting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants