Remove unnecessary suppressions and fix a few warnings #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
shawncal
reviewed
May 3, 2023
stephentoub
force-pushed
the
removesuppressions
branch
from
afafb3f
to
685e9f7
Compare
shawncal
previously approved these changes
May 6, 2023
|
Looks like I broke it (with the Update branch button). Fixing... stay tuned. |
shawncal
approved these changes
May 6, 2023
codebrain
pushed a commit
to searchpioneer/semantic-kernel
that referenced
this pull request
May 16, 2023
### Motivation and Context Remove warning suppressions for warnings that aren't firing in the build, anyway. ### Description Also fix a few warnings that are showing up.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
### Motivation and Context Remove warning suppressions for warnings that aren't firing in the build, anyway. ### Description Also fix a few warnings that are showing up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove warning suppressions for warnings that aren't firing in the build, anyway.
Description
Also fix a few warnings that are showing up.
Contribution Checklist
dotnet format