Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI Skill server-url configurations #797

Merged
Merged
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5e673da
Removing server-url from suggested Planner parameters
teresaqhoang May 3, 2023
0f82054
Merge branch 'main' into prohibit-planner-server-url-override
adrianwyatt May 3, 2023
7e8805e
removing ContainsKey check
teresaqhoang May 3, 2023
bdafba1
Merge branch 'prohibit-planner-server-url-override' of https://github…
teresaqhoang May 3, 2023
ad41431
Merge branch 'main' into prohibit-planner-server-url-override
adrianwyatt May 4, 2023
4790d1c
Merge branch 'main' into prohibit-planner-server-url-override
teresaqhoang May 4, 2023
67278c2
Merge branch 'main' into prohibit-planner-server-url-override
adrianwyatt May 4, 2023
5b95eb3
GitHub OpenAPI skill integration with planner (#792)
teresaqhoang May 4, 2023
0fb66c6
fixing default value bug
teresaqhoang May 4, 2023
ae35d1d
Merge branch 'main' into prohibit-planner-server-url-override
teresaqhoang May 4, 2023
37bbe07
Merge branch 'main' into prohibit-planner-server-url-override
teresaqhoang May 4, 2023
1ee0d71
Adding support for overriding server-url
teresaqhoang May 4, 2023
17cdfea
Updating other import methods
teresaqhoang May 4, 2023
d6d7f71
updating function calls
teresaqhoang May 4, 2023
8d46ae5
Reverting appsettings.json
teresaqhoang May 4, 2023
ab4c6f2
Merge branch 'main' into prohibit-planner-server-url-override
adrianwyatt May 5, 2023
5ac7a4d
Addressing comments
teresaqhoang May 5, 2023
fb488f4
Fix build breaks
adrianwyatt May 5, 2023
1478343
Update unit test with server-url
adrianwyatt May 5, 2023
7a52b46
Updated with PR comments
adrianwyatt May 5, 2023
5e8f0c3
dotnet format
adrianwyatt May 5, 2023
f977bf7
Fixup unit tests
adrianwyatt May 5, 2023
a382d56
Merge branch 'main' into prohibit-planner-server-url-override
adrianwyatt May 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,13 @@
plan = new Plan(goal);
}

// Planner should not suggest server-url as a parameter.
// Server URL should be be parsed from OpenAPI spec or provided by user
if (planData.Plan.Parameters.ContainsKey("server-url"))

Check warning on line 123 in dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Do not guard 'Dictionary.Remove(key)' with 'Dictionary.ContainsKey(key)'

Check warning on line 123 in dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Release)

Do not guard 'Dictionary.Remove(key)' with 'Dictionary.ContainsKey(key)'

Check warning on line 123 in dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Do not guard 'Dictionary.Remove(key)' with 'Dictionary.ContainsKey(key)'

Check warning on line 123 in dotnet/src/Extensions/Planning.ActionPlanner/ActionPlanner.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest, Debug)

Do not guard 'Dictionary.Remove(key)' with 'Dictionary.ContainsKey(key)'
adrianwyatt marked this conversation as resolved.
Show resolved Hide resolved
teresaqhoang marked this conversation as resolved.
Show resolved Hide resolved
{
planData.Plan.Parameters.Remove("server-url");
}

// Create a plan using the function and the parameters suggested by the planner
var variables = new ContextVariables();
foreach (KeyValuePair<string, object> p in planData.Plan.Parameters)
Expand Down