Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopilotChat: Enable email read and calendar read plugins #801

Merged
merged 12 commits into from May 5, 2023

Conversation

adrianwyatt
Copy link
Contributor

@adrianwyatt adrianwyatt commented May 4, 2023

Motivation and Context

Allow CopilotChat to ingest email and calendar context.

Description

  • Added email and calendar skills to CopilotChat WebAPI when MsGraph auth is available.
  • Added Gets to the Email and Calendar skills with supporting connector methods
  • Hard-coded the 'select' clauses to help minimize payload sizes to fit in token limits
  • Updated Constant.ts with Calendar.Read and Mail.Read scopes

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples labels May 4, 2023
@adrianwyatt adrianwyatt marked this pull request as ready for review May 4, 2023 04:04
@adrianwyatt adrianwyatt added the PR: ready for review All feedback addressed, ready for reviews label May 4, 2023
@adrianwyatt
Copy link
Contributor Author

adrianwyatt commented May 4, 2023

CC: @sw47 - We simplified and constrained the interfaces to enable the skill to work well with the current ActionPlanner and SequentialPlanner.

@adrianwyatt adrianwyatt self-assigned this May 4, 2023
teresaqhoang
teresaqhoang previously approved these changes May 4, 2023
@adrianwyatt adrianwyatt merged commit bdeeb0c into microsoft:main May 5, 2023
11 checks passed
@sw47
Copy link
Member

sw47 commented May 8, 2023

CC: @sw47 - We simplified and constrained the interfaces to enable the skill to work well with the current ActionPlanner and SequentialPlanner.

@adrianwyatt Thanks for adding this! Sorry I was OOF last week, so I didn't get a chance to reply.

I didn't see a UT for the new EmailSkill - will that be added in the future? I typically use the UT as an example/guidance how to effectively use the skill in different scenarios. I'm assuming I will deserialize the string return into the newly Email Models added, right?

@adrianwyatt adrianwyatt deleted the more-graph branch May 10, 2023 17:41
codebrain pushed a commit to searchpioneer/semantic-kernel that referenced this pull request May 16, 2023
### Motivation and Context
Allow CopilotChat to ingest email and calendar context.

### Description
- Added email and calendar skills to CopilotChat WebAPI when MsGraph
auth is available.
- Added Gets to the Email and Calendar skills with supporting connector
methods
- Hard-coded the 'select' clauses to help minimize payload sizes to fit
in token limits
- Updated Constant.ts with Calendar.Read and Mail.Read scopes
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
Allow CopilotChat to ingest email and calendar context.

### Description
- Added email and calendar skills to CopilotChat WebAPI when MsGraph
auth is available.
- Added Gets to the Email and Calendar skills with supporting connector
methods
- Hard-coded the 'select' clauses to help minimize payload sizes to fit
in token limits
- Updated Constant.ts with Calendar.Read and Mail.Read scopes
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
Allow CopilotChat to ingest email and calendar context.

### Description
- Added email and calendar skills to CopilotChat WebAPI when MsGraph
auth is available.
- Added Gets to the Email and Calendar skills with supporting connector
methods
- Hard-coded the 'select' clauses to help minimize payload sizes to fit
in token limits
- Updated Constant.ts with Calendar.Read and Mail.Read scopes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants