Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom context in plan execution #826

Merged
merged 7 commits into from
May 6, 2023

Commits on May 6, 2023

  1. Add support for custom context in plan execution

          Summary: This commit fixes a bug that allows users to pass a custom SKContext object to a plan invocation, which can override or augment the default context variables. This enables more flexibility and control over the plan execution and the output. The commit also adds a unit test to verify the functionality of the new feature.
    lemillermicrosoft authored and shawncal committed May 6, 2023
    Configuration menu
    Copy the full SHA
    d04f049 View commit details
    Browse the repository at this point in the history
  2. Add support for custom state and parameters in plan execution

          Summary: This commit adds the ability to execute a plan with a custom state and parameters, as well as overriding the input and other variables from the context. It also adds unit tests to verify the behavior of the plan execution with different combinations of state, parameters, and context. The commit modifies the GetNextStepVariables method in the Plan class to implement the logic for resolving the variables for each step in the plan. It also updates the documentation to explain the priority order for the variables.
    lemillermicrosoft authored and shawncal committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ec330b7 View commit details
    Browse the repository at this point in the history
  3. Use constant for main context variable name

          Summary: This commit replaces the hard-coded string "INPUT" with the constant ContextVariables.MainKey in two places where it is used to refer to the main context variable name. This improves readability and consistency, and avoids potential typos or mismatches.
    lemillermicrosoft authored and shawncal committed May 6, 2023
    Configuration menu
    Copy the full SHA
    4eab0ef View commit details
    Browse the repository at this point in the history
  4. formatting

    lemillermicrosoft authored and shawncal committed May 6, 2023
    Configuration menu
    Copy the full SHA
    4930221 View commit details
    Browse the repository at this point in the history
  5. formatting

    lemillermicrosoft authored and shawncal committed May 6, 2023
    Configuration menu
    Copy the full SHA
    764fa70 View commit details
    Browse the repository at this point in the history
  6. Remove unnecessary string.IsNullOrEmpty checks in Plan.cs

          Summary: This commit simplifies the logic for setting step variables in the Plan class by removing redundant checks for empty strings. The variables.Get and State.Get methods already handle empty strings internally, so there is no need to check them again. This makes the code more readable and consistent.
    lemillermicrosoft authored and shawncal committed May 6, 2023
    Configuration menu
    Copy the full SHA
    19df56f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2c38f13 View commit details
    Browse the repository at this point in the history