Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IChatCompletion Streaming Support #829

Merged
merged 19 commits into from May 8, 2023

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented May 5, 2023

Motivation and Context

Get streaming results from chat completion models using the IAsyncEnumerable pattern.

Closes #378
Resolves #378

Added samples how to use those as well as how to implement your own custom chat completion model using streaming capability.

Description

ChatCompletionStream

Co-authored-by: dedalo dedalo@gmail.com

Contribution Checklist

@RogerBarreto RogerBarreto requested a review from shawncal May 5, 2023 18:42
@RogerBarreto RogerBarreto self-assigned this May 5, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels May 5, 2023
@RogerBarreto RogerBarreto added the PR: ready for review All feedback addressed, ready for reviews label May 5, 2023
@shawncal shawncal force-pushed the features/ichatcompletion-stream branch from dc79269 to 0de719e Compare May 5, 2023 22:58
@shawncal shawncal mentioned this pull request May 7, 2023
@dedalo
Copy link
Contributor

dedalo commented May 7, 2023

This works great and helps implement signalr in chat applications wich improves user experience. Looking forward for the merge.

@shawncal shawncal merged commit ef85b61 into microsoft:main May 8, 2023
9 checks passed
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context
Get streaming results from chat completion models using the
IAsyncEnumerable pattern.

Closes microsoft#378 
Resolves microsoft#378 

Added samples how to use those as well as how to implement your own
custom chat completion model using streaming capability.

Co-authored-by: dedalo <dedalo@gmail.com>
Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
@RogerBarreto RogerBarreto deleted the features/ichatcompletion-stream branch December 5, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming support, implementation of IAsyncEnumberalbe
4 participants