Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower relevancy threshold and increase max relevant functions for seq… #860

Merged
merged 1 commit into from May 8, 2023

Conversation

lemillermicrosoft
Copy link
Member

@lemillermicrosoft lemillermicrosoft commented May 8, 2023

…uential planner

This commit adjusts the parameters of the sequential planner to improve its performance and accuracy. The relevancy threshold is lowered from 0.70 to 0.65, which allows more functions to be considered as potential candidates for the plan. The max relevant functions is increased from 20 to 30, which gives the planner more options to choose from and reduces the risk of missing a suitable function. These changes are expected to enhance the quality of the plans generated by the planner and make them more aligned with the user's intent.

Contribution Checklist

…uential planner

Summary: This commit adjusts the parameters of the sequential planner to improve its performance and accuracy. The relevancy threshold is lowered from 0.70 to 0.65, which allows more functions to be considered as potential candidates for the plan. The max relevant functions is increased from 20 to 30, which gives the planner more options to choose from and reduces the risk of missing a suitable function. These changes are expected to enhance the quality of the plans generated by the planner and make them more aligned with the user's intent.
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 8, 2023
@lemillermicrosoft
Copy link
Member Author

It's unclear what changed in the past few hours the make it so the embedding for the expected function dropped to ~0.66.

image

@lemillermicrosoft lemillermicrosoft marked this pull request as ready for review May 8, 2023 21:51
@shawncal shawncal merged commit 3fae7c4 into microsoft:main May 8, 2023
9 checks passed
@dluc
Copy link
Collaborator

dluc commented May 8, 2023

what changed that required to adjust the thresholds?

dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
microsoft#860)

This commit adjusts the parameters of the sequential planner to improve
its performance and accuracy. The relevancy threshold is lowered from
0.70 to 0.65, which allows more functions to be considered as potential
candidates for the plan. The max relevant functions is increased from 20
to 30, which gives the planner more options to choose from and reduces
the risk of missing a suitable function. These changes are expected to
enhance the quality of the plans generated by the planner and make them
more aligned with the user's intent.

Co-authored-by: Lee Miller <lemillermicrosoft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants