python: add chroma memory store #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joowon-dm-snu
changed the title
|
its draft, i'll add tests and update poetry soon |
|
Thanks for reopening this! Excited to get this in soon! |
awharrison-28
requested changes
May 11, 2023
awharrison-28
requested changes
May 12, 2023
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
python/semantic_kernel/connectors/memory/chroma/chroma_memory_store.py
Outdated
Show resolved
Hide resolved
|
Consider updating |
|
@awharrison-28 i think its almost done |
|
@joowon-dm-snu I just pushed a small change to the unit test workflow to hopefully fix the build issue for MacOS + Python 3.11 |
…owon-dm-snu/semantic-kernel into feat-python-add-chroma-memory
|
@joowon-dm-snu finally got a solution that works! |
awharrison-28
previously approved these changes
May 17, 2023
dluc
previously requested changes
May 17, 2023
mkarle
previously approved these changes
May 17, 2023
awharrison-28
approved these changes
May 17, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
Add support for Chroma https://docs.trychroma.com/ > Chroma is the open-source embedding database. Chroma makes it easy to build LLM apps by making knowledge, facts, and skills pluggable for LLMs. ### Motivation and Context * microsoft#403 Support for Chroma embedding database * microsoft#426 Python: feat: add chroma memory store * microsoft#449 Python: feat: add chroma memory store --------- Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Abby Harrison <abby.harrison@microsoft.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Chroma https://docs.trychroma.com/
Motivation and Context