-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copilot chat: ChatController #986
Copilot chat: ChatController #986
Conversation
samples/apps/copilot-chat-app/webapi/Controllers/CopilotChatControllers/ChatController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/SemanticKernelController.cs
Outdated
Show resolved
Hide resolved
f9b840f
to
ae04c25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactory. I've left some comments
samples/apps/copilot-chat-app/webapi/Controllers/CopilotChatControllers/ChatController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapp/src/libs/connectors/useConnectors.ts
Show resolved
Hide resolved
samples/apps/copilot-chat-app/webapi/Controllers/CopilotChatControllers/ChatController.cs
Outdated
Show resolved
Hide resolved
6f17760
to
ac0c20b
Compare
samples/apps/copilot-chat-app/copilotchat/Controllers/BotController.cs
Outdated
Show resolved
Hide resolved
samples/apps/copilot-chat-app/copilotchat/Extensions/ServiceExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worried the new project structure will confuse developers who are not familiar with the codebase. It's not straightforward to have two api project of the same app. And it's not common to include Controllers in a lib. I will let these big changes in but will work with Adrian offline to see if there's any mitigation.
Given said that, it's a great effort to separate components apart. Appreciate the huge refactory here.
I agree with Vivian, it's going to feel strange to have controllers in a project that does not appear to be runnable (I don't see a Program.cs) Another pattern to consider:
And if the objective is to allowing devs to deploy SKaaS with or without copilot chat, does this also imply that we should move the webapi project out of the copilot-chat-app folder? |
82a2ed9
82a2ed9
to
0cfbc0a
Compare
### Motivation and Context We would like developers to be able to deploy SKaaS that is not tightly coupled to Copilot Chat. This is the first step in creating more obvious boundaries between the WebApi service and CopilotChat specific components. ### Description 1. Group Chat related components to their own folders. 2. Strip out anything related to the current Chat features out of the SemanticKernelController. 3. Create a ChatController specifically to invoke the ChatSkill. 4. Refactor the WebApp to use the new ChatController. Make the service invocation pattern more consistent. 5. Remove the SKBotAudienceMember and refactor ChatStatus. Note that this component does not currently take any effect. But this component will be useful moving forward with the multi user support. 6. Disable implicit using.
### Motivation and Context We would like developers to be able to deploy SKaaS that is not tightly coupled to Copilot Chat. This is the first step in creating more obvious boundaries between the WebApi service and CopilotChat specific components. ### Description 1. Group Chat related components to their own folders. 2. Strip out anything related to the current Chat features out of the SemanticKernelController. 3. Create a ChatController specifically to invoke the ChatSkill. 4. Refactor the WebApp to use the new ChatController. Make the service invocation pattern more consistent. 5. Remove the SKBotAudienceMember and refactor ChatStatus. Note that this component does not currently take any effect. But this component will be useful moving forward with the multi user support. 6. Disable implicit using.
Motivation and Context
We would like developers to be able to deploy SKaaS that is not tightly coupled to Copilot Chat.
Description
Contribution Checklist
dotnet format