Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.ServiceFabric.AspNetCore.Configuration takes hard dependency on 3.1.274 of SF Services package and does not allow for higher version #61

Open
RamjotSingh opened this issue Sep 25, 2018 · 6 comments

Comments

@RamjotSingh
Copy link

Describe the bug
Current nuspec of Configuration package declares this in the nuspec



To Reproduce
Build the nuget package

Expected behavior
All versions above 3.1.274 should be allowed.

@amanbha , @chuanboz

@chuanboz
Copy link
Contributor

Do you see that's specific to Configuration package or apply to other Microsoft.ServiceFabric.AspNetCore.* package as well?

for reference, in configuration package, I declared the reference as this similar to other project:

<ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Configuration" Version="1.0.0" />
    <PackageReference Include="Microsoft.ServiceFabric.Services" Version="$(NugetPkg_Version_Microsoft_ServiceFabric_Services)" />
  </ItemGroup>

@chuanboz
Copy link
Contributor

In service-fabric-aspnetcore\properties\service_fabric_common.props, that variable is defined as below

<!-- Versions used for Microsoft.ServiceFabric.* nuget packages from other repos.-->
    <NugetPkg_Version_Microsoft_ServiceFabric>6.2.274</NugetPkg_Version_Microsoft_ServiceFabric>
    <NugetPkg_Version_Microsoft_ServiceFabric_Services>3.1.274</NugetPkg_Version_Microsoft_ServiceFabric_Services>

@amanbha
Copy link
Contributor

amanbha commented Sep 25, 2018

@chuanboz let me update this in develop branch to pull in latest release of Service Fabric runtime.

@RamjotSingh
Copy link
Author

The problem is the [] not the version. [] means a specific version needs to be installed which looks wrong :(

@RamjotSingh
Copy link
Author

I sent the PR to allow any version higher than the current one #63

@MartinDemberger
Copy link

I'm confused that this doesn't hurt so much people.
If you have a MVC.net-core project which references several fabric services this leads to version conflicts.

MyWebProject
    -> ServiceFabric.AspNetCore.Configuration [5.0.516] -> Microsoft.ServiceFabric.Services (= 5.0.516)
    -> MyFabricService -> Microsoft.ServiceFabric.Services.Remoting (5.0.521) -> Microsoft.ServiceFabric.Services (= 5.0.521)

If MyWebProject and MyFabricService are maintained in different teams this leads to conflicts that can't be resolved without a synchronized version increment to 5.0.521.
If MyFabricService totally out of control it's totally impossible to use a newer version.

I don't understand why the exact patch version must be set. Why isn't it possible to set the version to 5.0.516 (without the brackets) which means any version >= 5.0.516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants