Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use @Async instead of CompletableFuture #704

Merged
merged 1 commit into from
May 21, 2020

Conversation

mrm9084
Copy link
Collaborator

@mrm9084 mrm9084 commented May 21, 2020

Description

Fixes an issue when App Configuration is used in Java 11 in docker container with greater than 2 CPUs Refresh stops working.

This switches the CompletableFuture to @async which doesn't run into this issue.

@codecov-commenter
Copy link

Codecov Report

Merging #704 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #704   +/-   ##
=========================================
  Coverage     55.94%   55.94%           
  Complexity      757      757           
=========================================
  Files           181      181           
  Lines          3207     3207           
  Branches        237      237           
=========================================
  Hits           1794     1794           
  Misses         1277     1277           
  Partials        136      136           
Impacted Files Coverage Δ Complexity Δ
...loud/config/AppConfigurationAutoConfiguration.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...e/spring/cloud/config/AppConfigurationRefresh.java 88.88% <100.00%> (ø) 17.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd93c6...959c943. Read the comment docs.

Copy link

@drago-draganov drago-draganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link

@MSGaryWang MSGaryWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mrm9084 mrm9084 merged commit 7faf4ce into microsoft:master May 21, 2020
@mrm9084 mrm9084 deleted the asyncRefreshFix branch February 25, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants