Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Configuration Bug Fixes #723

Merged
merged 3 commits into from
Jul 13, 2020

Conversation

mrm9084
Copy link
Collaborator

@mrm9084 mrm9084 commented Jul 6, 2020

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2020

Codecov Report

Merging #723 into release/1.2.6 will decrease coverage by 0.08%.
The diff coverage is 72.97%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release/1.2.6     #723      +/-   ##
===================================================
- Coverage            55.94%   55.85%   -0.09%     
- Complexity             757      761       +4     
===================================================
  Files                  181      181              
  Lines                 3207     3228      +21     
  Branches               237      241       +4     
===================================================
+ Hits                  1794     1803       +9     
- Misses                1277     1288      +11     
- Partials               136      137       +1     
Impacted Files Coverage Δ Complexity Δ
...nfig/web/AppConfigurationWebAutoConfiguration.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../azure/spring/cloud/config/stores/ClientStore.java 50.74% <20.00%> (-10.28%) 12.00 <1.00> (-1.00)
...e/spring/cloud/feature/manager/FeatureManager.java 79.41% <50.00%> (-1.84%) 20.00 <0.00> (+1.00) ⬇️
.../config/AppConfigurationPropertySourceLocator.java 86.72% <100.00%> (+0.11%) 26.00 <0.00> (ø)
...e/spring/cloud/config/AppConfigurationRefresh.java 90.14% <100.00%> (+1.25%) 21.00 <11.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1777b19...28fa00a. Read the comment docs.

@mrm9084 mrm9084 marked this pull request as ready for review July 7, 2020 01:30
@mrm9084 mrm9084 changed the base branch from release/1.2.6 to 1.2.7 July 7, 2020 17:13
@mrm9084 mrm9084 changed the base branch from 1.2.7 to appconfiguration/1.2.7 July 7, 2020 17:15
@jialindai
Copy link

Hi Matt, the target branch should be appconfiguration/1.2.x, so future changes on 1.2.x can apply here.

@mrm9084 mrm9084 changed the base branch from appconfiguration/1.2.7 to appconfiguration/1.2.x July 8, 2020 15:34
@mrm9084 mrm9084 changed the base branch from appconfiguration/1.2.x to appconfiguration/1.2.7 July 8, 2020 15:34
@mrm9084 mrm9084 changed the base branch from appconfiguration/1.2.7 to appconfiguration/1.2.x July 8, 2020 15:37
@saragluna saragluna merged commit c73cd6f into microsoft:appconfiguration/1.2.x Jul 13, 2020
@mrm9084 mrm9084 deleted the 1.2.7 branch July 13, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants