Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy find/delete on DocumentQuery, #144. #156

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

Incarnation-p-lee
Copy link
Contributor

  • Adjust Unit test respectively.

Signed-off-by: Pan Li panli@microsoft.com

* Adjust Unit test respectively.

Signed-off-by: Pan Li <panli@microsoft.com>
@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #156 into master will increase coverage by 1.56%.
The diff coverage is 83.87%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #156      +/-   ##
========================================
+ Coverage   76.43%    78%   +1.56%     
========================================
  Files          39     37       -2     
  Lines         921    823      -98     
  Branches      120    106      -14     
========================================
- Hits          704    642      -62     
+ Misses        160    129      -31     
+ Partials       57     52       -5
Impacted Files Coverage Δ
...mosdb/repository/query/DocumentDbQueryCreator.java 82.35% <ø> (ø) ⬆️
.../spring/data/cosmosdb/core/query/CriteriaType.java 84.61% <ø> (ø)
...spring/data/cosmosdb/core/query/DocumentQuery.java 100% <ø> (ø) ⬆️
.../spring/data/cosmosdb/core/DocumentDbTemplate.java 76.19% <100%> (+5.92%) ⬆️
...osmosdb/core/generator/AbstractQueryGenerator.java 88% <50%> (ø) ⬆️
...zure/spring/data/cosmosdb/core/query/Criteria.java 84% <83.33%> (-16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e1e54...0b9f016. Read the comment docs.

Signed-off-by: Pan Li <panli@microsoft.com>
@Incarnation-p-lee Incarnation-p-lee merged commit 5a2f30e into master Aug 14, 2018
@Incarnation-p-lee Incarnation-p-lee deleted the remove-legacy-criteria-code branch August 14, 2018 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants