Implement AFTER and GREATER_THAN keyword #144 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
+ Coverage 78.61% 78.7% +0.09%
=========================================
Files 38 38
Lines 921 925 +4
Branches 130 130
=========================================
+ Hits 724 728 +4
Misses 134 134
Partials 63 63
Continue to review full report at Codecov.
|
Incarnation-p-lee
approved these changes
Aug 17, 2018
| Assert.isTrue(criteria.getSubjectValues().size() == 1, | ||
| "GREATER_THAN should have only one subject value"); | ||
|
|
||
| parameters.add(Pair.with(subject, criteria.getSubjectValues().get(0))); |
There was a problem hiding this comment.
I am not very sure if it works well when date, as we will convert date type to getTime(), before store in database. like this "date": 946656000000,
There was a problem hiding this comment.
Now it can store in database like "date": 946656000000.
# Conflicts: # src/main/java/com/microsoft/azure/spring/data/cosmosdb/core/generator/AbstractQueryGenerator.java # src/main/java/com/microsoft/azure/spring/data/cosmosdb/core/query/Criteria.java # src/main/java/com/microsoft/azure/spring/data/cosmosdb/core/query/CriteriaType.java # src/test/java/com/microsoft/azure/spring/data/cosmosdb/repository/integration/MemoRepositoryIT.java # src/test/java/com/microsoft/azure/spring/data/cosmosdb/repository/repository/MemoRepository.java
# Conflicts: # src/main/java/com/microsoft/azure/spring/data/cosmosdb/Constants.java # src/main/java/com/microsoft/azure/spring/data/cosmosdb/core/query/CriteriaType.java # src/test/java/com/microsoft/azure/spring/data/cosmosdb/repository/repository/ProjectRepository.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.