Add keyword in 144 #191
Add keyword in 144 #191
Conversation
Signed-off-by: Pan Li <panli@microsoft.com>
Signed-off-by: Pan Li <panli@microsoft.com>
Signed-off-by: Pan Li <panli@microsoft.com>
Signed-off-by: Pan Li <panli@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 80.76% 80.56% -0.21%
==========================================
Files 39 39
Lines 936 957 +21
Branches 118 123 +5
==========================================
+ Hits 756 771 +15
- Misses 122 125 +3
- Partials 58 61 +3
Continue to review full report at Codecov.
|
| @@ -55,7 +55,12 @@ private boolean isCrossPartitionQuery(@NonNull String keyName) { | |||
|
|
|||
| final Optional<Criteria> criteria = this.getSubjectCriteria(this.criteria, keyName); | |||
|
|
|||
| return criteria.map(criteria1 -> criteria1.getType() == CriteriaType.IS_EQUAL).orElse(true); | |||
| return criteria.map(criteria1 -> criteria1.getType() != CriteriaType.IS_EQUAL).orElse(true); | |||
There was a problem hiding this comment.
For case isEqual and other condition, seems the result is opposite? e.g., findByNameAndAgeGreaterThan, will return true, but actually should be false?
There was a problem hiding this comment.
typo from last PR, should be != here. Yes, the result is opposite. If not equal and OR keyword, should enable CrossPartitionKey.
|
|
||
| private boolean hasKeywordOr() { | ||
| // If there is OR keyword in DocumentQuery, the top node of Criteria must be OR type. | ||
| return this.criteria.getType() == CriteriaType.OR; |
There was a problem hiding this comment.
Why not need to check the subCriteria inside the criteria ?
There was a problem hiding this comment.
Actually, here we check is there any OR keyword in criteria. Any OR keyword will make the semantic to query cross ParititonKey.
Signed-off-by: Pan Li <panli@microsoft.com>
Incarnation-p-lee
force-pushed
the
add-keyword-IN-144
branch
from
1d8ecfa
to
5b1511d
Compare
No description provided.