-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL Server 2019 workflow contained on runner VM #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantleonard
requested changes
Jun 27, 2024
seantleonard
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending 2 nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new .yaml file which will handle the transition of SQL2019 ML Utils from utilizing Azure Resources. This aligns SQLMLUtils for SQL Server 2019 with the first phase of the security push.
Errors that are happening during the running of the pipeline are carried over from the previous SQLMLUtils environment and are related to version updates that need be properly handled. These changes are out of scope for this PR.
To demonstrate that the SQL Server 2019 environment is setup correctly we have added a SPEES task both for Python and R, so that we can validate that the GHA is capable of correctly executing an external script using the machine learning services.
Successful pipeline run: https://github.com/microsoft/sqlmlutils/actions/runs/9703488737