Enable column encryption setting #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llali
reviewed
Jan 13, 2020
src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectionDetails.cs
Outdated
Show resolved
Hide resolved
llali
reviewed
Jan 13, 2020
src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectionDetails.cs
Show resolved
Hide resolved
llali
reviewed
Jan 14, 2020
src/Microsoft.SqlTools.ServiceLayer/Connection/ConnectionService.cs
Outdated
Show resolved
Hide resolved
llali
reviewed
Jan 14, 2020
test/Microsoft.SqlTools.ServiceLayer.UnitTests/Connection/ConnectionDetailsTests.cs
Show resolved
Hide resolved
…y, add resource string, and add unit tests
kburtram
requested changes
Jan 16, 2020
src/Microsoft.SqlTools.ServiceLayer/Connection/Contracts/ConnectionDetails.cs
Outdated
Show resolved
Hide resolved
kburtram
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ADS within the advanced properties of the connection details dialog, there is an option to enable or disable column encryption for the Always Encrypted feature.
Changing this option is currently a NOOP.
This change-set enables the functionality of this option by "wiring it up" in sqltoolsservice.