Enable Always Encrypted enclave connection parameters #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncrypted is set to disabled.
Charles-Gagnon
approved these changes
Feb 10, 2020
| DisplayName = "Column encryption setting", | ||
| Description = "Default column encryption setting for all the commands on the connection", | ||
| DisplayName = "Always Encrypted", | ||
| Description = "Enables or disables Always Encrypted for the connection", |
There was a problem hiding this comment.
Where is this new description coming from? No issues with the change - just not sure I understand the context for the change here.
There was a problem hiding this comment.
Our Program Manager wanted it to match the verbiage that exists in SSMS for user experience parity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request "wires up" the two new advanced connection security properties; Attestation Protocol and Enclave Attestation URL. These new properties will be used in conjunction with the Always Encrypted property (formerly known as Column Encryption) to support the Always Encrypted with secure enclaves feature
A corresponding pull request has been submitted to the Azure Data Studio project which add these options to the UI.