Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: Add Benchmark - Add the source code of rocm kernel launch overhead benchmark. #136

Merged
merged 6 commits into from Jul 27, 2021
Merged

Benchmarks: Add Benchmark - Add the source code of rocm kernel launch overhead benchmark. #136

merged 6 commits into from Jul 27, 2021

Conversation

yukirora
Copy link
Contributor

@yukirora yukirora commented Jul 26, 2021 •
edited by cp5555

Description
Add the source code of rocm kernel launch overhead benchmark.

Major Revision

  • Revise cmake build logic to support both cuda and rocm

@yukirora yukirora added benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks labels Jul 26, 2021
@yukirora yukirora requested a review from a team as a code owner July 26, 2021 09:36
@codecov
Copy link

codecov bot commented Jul 26, 2021 •
edited

Codecov Report

Merging #136 (349e04c) into main (fdc33f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files          48       48           
  Lines        2496     2496           
=======================================
  Hits         2192     2192           
  Misses        304      304
Flag Coverage Δ
cpu-unit-test 72.25% <ø> (ø)
cuda-unit-test 87.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc33f4...349e04c. Read the comment docs.

@cp5555 cp5555 self-assigned this Jul 26, 2021
@cp5555 cp5555 requested review from abuccts and guoshzhao July 26, 2021 11:58
@cp5555 cp5555 mentioned this pull request Jul 27, 2021
Closed
33 tasks
@cp5555 cp5555 merged commit 1ee8f7d into main Jul 27, 2021
@cp5555 cp5555 deleted the v-yujiang/kernel-launch-rocm branch July 27, 2021 14:22
@cp5555 cp5555 added the ROCm label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cp5555 cp5555 cp5555 approved these changes

@guoshzhao guoshzhao guoshzhao approved these changes

@abuccts abuccts Awaiting requested review from abuccts

Assignees

@cp5555 cp5555

Labels
benchmarks SuperBench Benchmarks micro-benchmarks Micro Benchmark Test for SuperBench Benchmarks ROCm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yukirora @cp5555 @guoshzhao