Benchmarks: Add Benchmark - Add ib validation tool source code #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 59 59
Lines 2922 2922
=======================================
Hits 2588 2588
Misses 334 334
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
cp5555
reviewed
Sep 28, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
cp5555
reviewed
Sep 28, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
jithinjosepkl
approved these changes
Sep 29, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
| int size = run_pairs_in_parallel.size(); | ||
| // invoke function to run cmd in multi threads mode for each rank in the pairs | ||
| unordered_map<int, std::future<float>> threads; | ||
| for (int index = 0; index < size; index++) { |
There was a problem hiding this comment.
should we limit max number of active threads? (given that some clusters can be really large, and also with multiple NICs per node)
There was a problem hiding this comment.
add limit for the max num of threads at the same time, if expired, split the line
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
cp5555
reviewed
Sep 30, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
cp5555
reviewed
Sep 30, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
cp5555
reviewed
Sep 30, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
abuccts
reviewed
Oct 11, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Show resolved
Hide resolved
superbench/benchmarks/micro_benchmarks/ib_validation_performance/CMakeLists.txt
Outdated
Show resolved
Hide resolved
abuccts
approved these changes
Oct 20, 2021
superbench/benchmarks/micro_benchmarks/ib_validation_performance/ib_validation_performance.cc
Outdated
Show resolved
Hide resolved
cp5555
added
benchmarks
added 2 commits
October 21, 2021 10:47
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add IB validation tool source code. IB validation tool is a tool to validate IB traffic of different pattern in multi nodes flexibly
Major Revision