Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer: Initialization - Add baseline-based data diagnosis module #242

Merged
merged 29 commits into from
Dec 8, 2021

Conversation

yukirora
Copy link
Contributor

Description
Add data diagnosis module.

Major Revision

  • Add DataDiagnosis class to support rule-based data diagnosis for result summary jsonl file of multi nodes
  • Add RuleOp class to define rule operators

@yukirora yukirora requested a review from a team as a code owner November 23, 2021 07:25
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #242 (0e71e3e) into main (213ab14) will decrease coverage by 0.18%.
The diff coverage is 84.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   87.79%   87.61%   -0.19%     
==========================================
  Files          66       70       +4     
  Lines        3639     3947     +308     
==========================================
+ Hits         3195     3458     +263     
- Misses        444      489      +45     
Flag Coverage Δ
cpu-unit-test 72.04% <84.53%> (+1.12%) ⬆️
cuda-unit-test 87.56% <84.74%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/analyzer/data_diagnosis.py 81.61% <81.61%> (ø)
superbench/analyzer/file_handler.py 82.17% <82.17%> (ø)
superbench/analyzer/diagnosis_rule_op.py 94.02% <94.02%> (ø)
superbench/analyzer/__init__.py 100.00% <100.00%> (ø)
superbench/common/utils/logging.py 100.00% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 213ab14...0e71e3e. Read the comment docs.

@guoshzhao guoshzhao merged commit c13ed2a into main Dec 8, 2021
@guoshzhao guoshzhao deleted the v-yujiang/data-diagnosis branch December 8, 2021 10:22
@cp5555 cp5555 added the tool label Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants