Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Refine test cases for microbenchmark #268

Merged
merged 6 commits into from Dec 16, 2021

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Dec 15, 2021

Description

Refine test cases for microbenchmark:

  • Refine test fixture, add BenchmarkTestCase class.
  • Refine test data.
  • Resolve no numa issue for test_ib_loopback_util case.

Refine test fixture for microbenchmark tests, add BenchmarkTestCase
class.
@abuccts abuccts added the test Unit tests, lint or format check related label Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #268 (efd7d13) into release/0.4 (a15f773) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/0.4     #268      +/-   ##
===============================================
- Coverage        87.83%   87.65%   -0.19%     
===============================================
  Files               75       75              
  Lines             4358     4358              
===============================================
- Hits              3828     3820       -8     
- Misses             530      538       +8     
Flag Coverage Δ
cpu-unit-test 71.85% <ø> (-0.19%) ⬇️
cuda-unit-test 87.60% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/common/utils/network.py 38.70% <0.00%> (-25.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15f773...efd7d13. Read the comment docs.

Fix test.
tests/helper/testcase.py Outdated Show resolved Hide resolved
Refine test data.
Update according to comment.
Resolve no numa issue for test_ib_loopback_util case.
@abuccts abuccts marked this pull request as ready for review December 16, 2021 05:39
@abuccts abuccts requested a review from a team as a code owner December 16, 2021 05:39
@abuccts abuccts merged commit 020a63c into release/0.4 Dec 16, 2021
@abuccts abuccts deleted the xiongyf/microbenchmark-test-refine branch December 16, 2021 08:59
@cp5555 cp5555 mentioned this pull request Dec 20, 2021
abuccts added a commit that referenced this pull request Dec 29, 2021
__Description__

Refine test cases for microbenchmark:
* Refine test fixture, add BenchmarkTestCase class.
* Refine test data.
* Resolve no numa issue for test_ib_loopback_util case.
abuccts added a commit that referenced this pull request Dec 30, 2021
__Description__

Cherry-pick  bug fixes from v0.4.0 to main.

__Major Revisions__

* Bug - Fix issues for Ansible and benchmarks (#267)
* Tests - Refine test cases for microbenchmark (#268)
* Bug - Build openmpi with ucx support in rocm dockerfiles (#269)
* Benchmarks: Fix Bug - Fix fio build issue (#272)
* Docs - Unify metric and add doc for cublas and cudnn functions (#271)
* Monitor: Revision - Add 'monitor/' prefix to monitor metrics in result summary (#274)
* Bug - Fix bug of detecting if gpu_index is none (#275)
* Bug - Fix bugs in data diagnosis (#273)
* Bug - Fix issue that the root mpi rank may not be the first in the hostfile (#270)
* Benchmarks: Configuration - Update inference and network benchmarks in configs (#276)
* Docs - Upgrade version and release note (#277)

Co-authored-by: Yuting Jiang <v-yutjiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Unit tests, lint or format check related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants