CLI - Add command sb benchmark [list,list-parameters] #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add command `sb benchmark list` and `sb benchmark list-parameters` to support listing all optional paramters for benchmarks.
cp5555
reviewed
Jan 4, 2022
Fix unit test.
Add docs and tests.
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 88.53% 88.61% +0.08%
==========================================
Files 75 76 +1
Lines 4368 4401 +33
==========================================
+ Hits 3867 3900 +33
Misses 501 501
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
reviewed
Jan 6, 2022
cp5555
approved these changes
Jan 6, 2022
Update command description.
guoshzhao
reviewed
Jan 18, 2022
Comment on lines
+98
to
+99
| self.cmd('sb benchmark list-parameters', checks=[NoneCheck()]) | ||
| self.cmd('sb benchmark list-parameters -n pytorch-[a-z]+', checks=[NoneCheck()]) |
There was a problem hiding this comment.
Do we need to check the exit_code?
There was a problem hiding this comment.
by default expect_failure is False so exit code is expected to be 0, otherwise the case will fail
guoshzhao
approved these changes
Jan 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add command
sb benchmark listandsb benchmark list-parametersto support listing all optional parameters for benchmarks.Examples
$ sb benchmark list-parameters -n mem-bw === mem-bw === optional arguments: --bin_dir str Specify the directory of the benchmark binary. --duration int The elapsed time of benchmark in seconds. --mem_type str [str ...] Memory types to benchmark. E.g. htod dtoh dtod. --memory str Memory argument for bandwidthtest. E.g. pinned unpinned. --run_count int The run count of benchmark. --shmoo_mode Enable shmoo mode for bandwidthtest. default values: {'bin_dir': None, 'duration': 0, 'mem_type': ['htod', 'dtoh'], 'memory': 'pinned', 'run_count': 1}Major Revisions
sb benchmark listto list benchmarks matching given name.sb benchmark list-parametersto list parameters for benchmarks which match given name.Minor Revisions