Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks: Add Benchmark - Add FAMBench based on docker benchmark #338

Merged
merged 4 commits into from Apr 11, 2022

Conversation

guoshzhao
Copy link
Contributor

Description
Integrate FAMBench into superbench based on docker implementation:
https://github.com/facebookresearch/FAMBench

The script to run all benchmarks is:
https://github.com/facebookresearch/FAMBench/blob/main/benchmarks/run_all.sh

@guoshzhao guoshzhao added benchmarks SuperBench Benchmarks docker-benchmarks Docker Benchmark Test for SuperBench Benchmarks labels Apr 9, 2022
@guoshzhao guoshzhao requested review from cp5555 and abuccts April 9, 2022 12:10
@guoshzhao guoshzhao requested a review from a team as a code owner April 9, 2022 12:10
@cp5555 cp5555 assigned guoshzhao and unassigned cp5555 Apr 10, 2022
@cp5555 cp5555 mentioned this pull request Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #338 (2026cea) into main (8dc19ca) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
+ Coverage   88.89%   88.91%   +0.01%     
==========================================
  Files          80       81       +1     
  Lines        4962     4997      +35     
==========================================
+ Hits         4411     4443      +32     
- Misses        551      554       +3     
Flag Coverage Δ
cpu-unit-test 74.63% <91.66%> (+0.16%) ⬆️
cuda-unit-test 88.85% <91.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperbench/benchmarks/docker_benchmarks/fambench.py 91.17% <91.17%> (ø)
...uperbench/benchmarks/docker_benchmarks/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc19ca...2026cea. Read the comment docs.

@guoshzhao guoshzhao merged commit 80dcc8a into main Apr 11, 2022
@guoshzhao guoshzhao deleted the guzhao/fambench branch April 11, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks SuperBench Benchmarks docker-benchmarks Docker Benchmark Test for SuperBench Benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants