Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: Update rccl version and fix issue in rocm5.1.1 dockerfile #354

Merged
merged 6 commits into from May 27, 2022

Conversation

yukirora
Copy link
Contributor

@yukirora yukirora commented May 25, 2022

Description
Update rccl version and fix issue in rocm5.1.1 dockerfile.

@yukirora yukirora requested a review from a team as a code owner May 25, 2022 16:11
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #354 (436efa6) into main (81a4146) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #354   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files          81       81           
  Lines        5019     5019           
=======================================
  Hits         4463     4463           
  Misses        556      556           
Flag Coverage Δ
cpu-unit-test 74.74% <ø> (ø)
cuda-unit-test 88.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a4146...436efa6. Read the comment docs.

@yukirora yukirora closed this May 25, 2022
@yukirora yukirora reopened this May 26, 2022
@yukirora yukirora changed the title Dockerfile: Update timeout in pipeline Dockerfile: Update rccl version and fix issue in rocm5.1.1 dockerfile May 26, 2022
@cp5555 cp5555 requested a review from abuccts May 26, 2022 12:36
dockerfile/rocm5.1.1-pytorch1.10.0.dockerfile Outdated Show resolved Hide resolved
@yukirora yukirora merged commit e08b6d3 into main May 27, 2022
@yukirora yukirora deleted the v-yutji/fix-rocm5.1-dockerfile branch May 27, 2022 02:46
@cp5555 cp5555 mentioned this pull request Jun 9, 2022
27 tasks
@cp5555 cp5555 added CI/CD Continuous integration or deployment ROCm labels Jun 15, 2022
@yukirora yukirora mentioned this pull request Aug 22, 2022
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration or deployment ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants