Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROCm Dockerfile #361

Merged
merged 6 commits into from Jun 19, 2022
Merged

Update ROCm Dockerfile #361

merged 6 commits into from Jun 19, 2022

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Jun 14, 2022

Description

Update ROCm Dockerfile.

Major Revisions

  • Add dockerfile for ROCm 5.1.3
  • Merge 5.1.x and 5.0.x dockerfile
  • Remove 4.2 and 4.0 legacy
  • Update build pipeline accordingly

Add rocm5.1.3 dockerfile.
@abuccts abuccts added the CI/CD Continuous integration or deployment label Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #361 (99b40b6) into main (60a3c74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files          81       81           
  Lines        5026     5026           
=======================================
  Hits         4468     4468           
  Misses        558      558           
Flag Coverage Δ
cpu-unit-test 74.74% <ø> (ø)
cuda-unit-test 88.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a3c74...99b40b6. Read the comment docs.

@abuccts abuccts force-pushed the xiongyf/update-rocm-dockerfile branch from fbfd080 to f024751 Compare June 14, 2022 12:31
Fix condition.
@abuccts abuccts force-pushed the xiongyf/update-rocm-dockerfile branch from f024751 to c8a7917 Compare June 14, 2022 12:44
@cp5555 cp5555 requested a review from hpourreza June 15, 2022 02:39
@abuccts abuccts marked this pull request as ready for review June 15, 2022 06:15
@abuccts abuccts requested a review from a team as a code owner June 15, 2022 06:15
Update args.
@cp5555 cp5555 added the ROCm label Jun 15, 2022
@abuccts abuccts merged commit 483bf78 into main Jun 19, 2022
@abuccts abuccts deleted the xiongyf/update-rocm-dockerfile branch June 19, 2022 09:26
@cp5555 cp5555 mentioned this pull request Jun 20, 2022
27 tasks
@yukirora yukirora mentioned this pull request Aug 22, 2022
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Continuous integration or deployment ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants