Fix issues in ib loopback benchmark #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix several issues in ib loopback benchmark: * use `--report_gbits` and divide by 8 to get GB/s, previous results are MiB/s / 1000 * use the ib_write_bw binary built in third_party instead of system path * update the metrics name so that different hca indices have same metric
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 81 81
Lines 5016 5017 +1
=======================================
+ Hits 4459 4460 +1
Misses 557 557
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yzygitzh
approved these changes
Jun 29, 2022
cp5555
approved these changes
Jun 29, 2022
jeseszhang1010
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix several issues in ib loopback benchmark:
--report_gbitsand divide by 8 to get GB/s, previous results are MiB/s / 1000