ModelBenchmarks - Fix early stop logic due to num_steps. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukirora
reviewed
Apr 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #522 +/- ##
==========================================
- Coverage 87.24% 87.20% -0.05%
==========================================
Files 89 89
Lines 5965 5969 +4
==========================================
+ Hits 5204 5205 +1
- Misses 761 764 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cp5555
approved these changes
Apr 17, 2023
cp5555
reviewed
Apr 22, 2023
yukirora
approved these changes
Apr 26, 2023
cp5555
added
benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Model benchmarks can stop due to
num_stepsordurationconfig which will take effect when the value is set greater than 0.If both are set greater than 0, the earliest condition reached will work.