Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner - Add signal handler in runner #530

Merged
merged 3 commits into from May 23, 2023
Merged

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented May 8, 2023

Add signal handler in runner to gracefully exit when receiving SIGINT (Ctrl+C) or SIGTERM during benchmark execution.

Add signal handler in runner to gracefully exit when receiving SIGINT or
SIGTERM during benchmark execution.
@abuccts abuccts added the runner SuperBench Runner label May 8, 2023
@abuccts abuccts requested a review from a team as a code owner May 8, 2023 10:34
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #530 (d5d0c73) into main (4c0d96e) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   87.20%   87.15%   -0.05%     
==========================================
  Files          89       89              
  Lines        5969     5978       +9     
==========================================
+ Hits         5205     5210       +5     
- Misses        764      768       +4     
Flag Coverage Δ
cpu-python3.6-unit-test 73.42% <60.00%> (-0.03%) ⬇️
cpu-python3.7-unit-test 73.42% <60.00%> (-0.03%) ⬇️
cpu-python3.8-unit-test 73.89% <60.00%> (-0.03%) ⬇️
cuda-unit-test 87.08% <60.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/runner/ansible.py 98.11% <ø> (ø)
superbench/runner/runner.py 86.50% <60.00%> (-1.46%) ⬇️

@cp5555 cp5555 mentioned this pull request May 9, 2023
21 tasks
superbench/runner/runner.py Outdated Show resolved Hide resolved
@cp5555 cp5555 requested a review from guoshzhao May 9, 2023 05:04
Fix unit test.
Update.
@abuccts abuccts merged commit a1cd3c9 into main May 23, 2023
21 of 22 checks passed
@abuccts abuccts deleted the xiongyf/runner-sig-handler branch May 23, 2023 09:25
@yukirora yukirora mentioned this pull request Jul 12, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner SuperBench Runner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants