New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runner - Add signal handler in runner #530
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add signal handler in runner to gracefully exit when receiving SIGINT or SIGTERM during benchmark execution.
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
==========================================
- Coverage 87.20% 87.15% -0.05%
==========================================
Files 89 89
Lines 5969 5978 +9
==========================================
+ Hits 5205 5210 +5
- Misses 764 768 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cp5555
reviewed
May 9, 2023
Fix unit test.
cp5555
approved these changes
May 11, 2023
guoshzhao
reviewed
May 12, 2023
guoshzhao
reviewed
May 12, 2023
guoshzhao
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add signal handler in runner to gracefully exit when receiving SIGINT (Ctrl+C) or SIGTERM during benchmark execution.