Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools - Add runner for sys info and update docs #532

Merged
merged 17 commits into from
Jun 29, 2023
Merged

Conversation

yukirora
Copy link
Contributor

Description
Add runner for sys info to automatically collect on multiple nodes and update related docs.

Major Revision

  • add runner for sys info which will check docker status and run sb node info on all nodes' docker and fetch results from all nodes

Minor Revision

  • update cli and system-info doc
  • update sb node info to save output info output-dir/sys-info.json

@yukirora yukirora added the tool label May 23, 2023
@yukirora yukirora requested review from cp5555 and abuccts May 23, 2023 03:51
@yukirora yukirora requested a review from a team as a code owner May 23, 2023 03:51
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #532 (0efc70c) into main (3a6622f) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
- Coverage   87.11%   86.97%   -0.14%     
==========================================
  Files          89       89              
  Lines        5985     6006      +21     
==========================================
+ Hits         5214     5224      +10     
- Misses        771      782      +11     
Flag Coverage Δ
cpu-python3.6-unit-test 73.31% <50.00%> (-0.10%) ⬇️
cpu-python3.8-unit-test 73.78% <50.00%> (-0.10%) ⬇️
cuda-unit-test 86.86% <50.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superbench/cli/_help.py 100.00% <ø> (ø)
superbench/runner/runner.py 82.46% <9.09%> (-4.04%) ⬇️
superbench/cli/_handler.py 91.54% <50.00%> (-1.21%) ⬇️
superbench/cli/_commands.py 100.00% <100.00%> (ø)
superbench/cli/_node_handler.py 86.66% <100.00%> (+11.66%) ⬆️

superbench/cli/_commands.py Outdated Show resolved Hide resolved
@cp5555 cp5555 mentioned this pull request Jun 14, 2023
21 tasks
docs/cli.md Show resolved Hide resolved
superbench/cli/_handler.py Outdated Show resolved Hide resolved
superbench/cli/_handler.py Outdated Show resolved Hide resolved
docs/user-tutorial/system-config.md Outdated Show resolved Hide resolved
superbench/cli/_help.py Outdated Show resolved Hide resolved
superbench/cli/_help.py Outdated Show resolved Hide resolved
superbench/cli/_node_handler.py Outdated Show resolved Hide resolved
superbench/runner/runner.py Outdated Show resolved Hide resolved
docs/user-tutorial/system-config.md Outdated Show resolved Hide resolved
docs/cli.md Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
@yukirora yukirora enabled auto-merge (squash) June 29, 2023 03:08
@yukirora yukirora merged commit ed027e4 into main Jun 29, 2023
22 of 23 checks passed
@yukirora yukirora deleted the yutji/sysinfo-runner branch June 29, 2023 06:09
@yukirora yukirora mentioned this pull request Jul 12, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants